thar-be-updates: migrate to use configuration file

[jmt-lab]

Issue number: #3625

Closes #3625

Description of changes:

This change migrates the thar-be-updates tool to utilize a configuration file at /etc/thar-be-updates.toml instead of calling back to the settings api.

log:

• migration and template
• migrate thar-be-updates tool to read settings from a config file

Testing done:
Tested update from 1.18.0 -> 1.18.1 and ensured settings get populated appropriately

• Ran cargo +nightly udeps to ensure all unused dependencies have been removed
• Pass the settings on first boot via userdata. Verify config.

Test Results

User Data

[settings.updates]
ignore-waves = true
metadata-base-url = "https://d160pk1ajy78su.cloudfront.net/tough-async/live/metadata/aws-ecs-2/aarch64"
targets-base-url = "https://d160pk1ajy78su.cloudfront.net/tough-async/live/targets"

Generated Config

version-lock = "latest"

• cat /etc/os-release record your build ID include commit sha, record this

Version	os-release
1.19.2	BUILD_ID=29cc92cc
1.19.3	BUILD_ID=01c5e345

• Use apiclient to update relevant settings at runtime. Verify config was updated correctly.

Test Info

Command Run

apiclient set settings.updates.version-lock="1.19.3"

Resulting Config File

version-lock = "1.19.3"

• Downgrade to older version.
  • verify connectivity
  • cat /etc/os-release to verify lower version
  • verify that migrations have changed the metadata/settings as expected (i.e. they are gone from the datastore, or lists have been changed back)

Test Info

/etc/os-release upon downgrade

VERSION_ID=1.19.2
BUILD_ID=29cc92cc

Migrations

apiclient get configuration-files.thar-be-updates-toml
{}

apiclient get services.thar-be-updates
{}

cat var/lib/bottlerocket/datastore/current/live/settings/updates.affected-services
["updog"]

• Upgrade to newer version.
  • verify connectivity
  • cat /etc/os-release to verify version
  • verify config file

Test Info

/etc/os-release upon upgrade

VERSION_ID=1.19.3
BUILD_ID=01c5e345

Config File

version-lock = "latest"

Migrations

apiclient get configuration-files.thar-be-updates-toml
{
  "configuration-files": {
    "thar-be-updates-toml": {
      "path": "/etc/thar-be-updates.toml",
      "template-path": "/usr/share/templates/thar-be-updates-toml"
    }
  }
}

apiclient get services.thar-be-updates
{
  "services": {
    "thar-be-updates": {
      "configuration-files": [
        "thar-be-updates-toml"
      ],
      "restart-commands": []
    }
  }
}

cat var/lib/bottlerocket/datastore/current/live/settings/updates.affected-services
["updog","thar-be-updates"]

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

[jmt-lab]

fix build issue where i left unused imports

[jmt-lab]

• Rebased off latest
• Tested upgrade -> downgrade ensured everything is clean
• Removed tokio dependency
• Adjusted config_path use

[webern]

Let's merge this first #3768 then rebase your PR to align on 1.19.2

[webern]

error: unused import: `PathBuf`
  --> api/thar-be-updates/src/status.rs:13:23
   |
13 | use std::path::{Path, PathBuf};
   |                       ^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

[jmt-lab]

updated on latest

[jmt-lab]

Fix the if condition around the boolean value causing it to not be rendered when false

[webern]

Nice, testing looks good.

[jmt-lab]

Updated per ben's comments, will begin testing now

[bcressey]

LGTM assuming testing checks out.