settings: add aws settings extension #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Feb 1, 2024
sam-berning
force-pushed
the
aws-settings-extension
branch
from
4769eaf
to
82f0ba9
Compare
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
Signed-off-by: Sam Berning <bernings@amazon.com>
sam-berning
force-pushed
the
aws-settings-extension
branch
from
82f0ba9
to
6f870f0
Compare
|
^ rebased on top of #3770 |
ecpullen
approved these changes
Feb 9, 2024
webern
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3655
Description of changes:
Creates an
awssettings extension and uses it in every variant's settings model.Testing done:
Built an
aws-devvariant with thesettings-awspackage installed. Called apiclient to verify that the aws settings worked as before. Also called the settings extension to verify that it was behaving as expected.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.