add k8s-1.30 package and variants boilerplate #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Mar 29, 2024
packages/ecr-credential-provider-1.30/ecr-credential-provider-1.30.spec
Outdated
Show resolved
Hide resolved
|
^escape commented out macros |
4 tasks
bcressey
approved these changes
Mar 29, 2024
yeazelm
approved these changes
Mar 29, 2024
Adds boiler plate for k8s-1.30 variants based on previous addition of k8s variants. This commit does not add the actual k8s-1.30 sources, but rather sets the stage for incremental changes to k8s-1.30 variants. This adds a k8s-1.30 package. Existing 1.29 models are moved to be 1.30, with symlinks created for 1.29 models to point to the new locations. For now, the k8s-1.30 package points to the k8s-1.29 source. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
|
^fix build by specifying kubelet dependency on ecr-credential-provider-1.29, since ecr-credential-provider-1.30 isn't available yet. error was: built all k8s-1.30 variants to confirm. |
bcressey
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Adds boiler plate for k8s-1.30 variants based on previous addition of k8s variants. This commit does not add the actual k8s-1.30 sources, but rather sets the stage for incremental changes to k8s-1.30 variants.
This adds a k8s-1.30 package. Existing 1.29 models are moved to be 1.30, with symlinks created for 1.29 models to point to the new locations. For now, the k8s-1.30 package points to the k8s-1.29 source.
Testing done:
No testing other than
cargo make -e BUILDSYS_VARIANT=aws-k8s-1.30, just boilerplate. PR to add real k8s-1.30 sources will include full testing.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.