Build: Update twoliter to v0.1.0 & SDK to v0.40.0 #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumukhballal
force-pushed
the
update_bottlerocket
branch
from
3658382
to
8a413ac
Compare
webern
approved these changes
Apr 9, 2024
|
It would be good to get more detail in "clippy fixes" (for which version? Why is the truncate addition correct / safe?) E.g. LGTM otherwise. |
bcressey
approved these changes
Apr 9, 2024
sumukhballal
force-pushed
the
update_bottlerocket
branch
3 times, most recently
from
f411ce2
to
1e06b7b
Compare
bcressey
approved these changes
Apr 10, 2024
sumukhballal
force-pushed
the
update_bottlerocket
branch
from
1e06b7b
to
1936984
Compare
jpculp
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # N/A
Description of changes:
truncate(true)option because it always creates a fresh file (removes old contents if the file already exists).Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.