updog: Make check-update wave aware #615
Conversation
|
While wave awareness should be default, I think we'll want to add a flag to |
|
While this technically doesn't change that ( |
sam-aws
force-pushed
the
no-updates-here
branch
from
9e2c4d6
to
ad134af
Compare
|
Updated so that |
sam-aws
force-pushed
the
no-updates-here
branch
from
ad134af
to
6c51a6e
Compare
workspaces/updater/updog/src/main.rs
Outdated
| @@ -336,6 +337,26 @@ fn update_flags() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// List any available update that matches the current flavor, ignoring waves | |||
| fn list_updates(manifest: &Manifest, flavor: &str, json: bool) -> Result<()> { | |||
There was a problem hiding this comment.
This, and other "flavor" references, should be updated to reflect the usage of "variant" vs "flavor".
There was a problem hiding this comment.
Chatted offline, we're holding off for a dedicated changeset!
There was a problem hiding this comment.
nit: It looks like the args in applicable_updates were updated to use variant, should this usage also then be updated to match?
sam-aws
force-pushed
the
no-updates-here
branch
2 times, most recently
from
fbb3375
to
6a2ae66
Compare
|
Updated to remove that stray |
sam-aws
force-pushed
the
no-updates-here
branch
from
6a2ae66
to
af034c3
Compare
sam-aws
force-pushed
the
no-updates-here
branch
from
af034c3
to
f022f83
Compare
|
Updated to use "ignore_waves" consistently, update the help text for |
sam-aws
force-pushed
the
no-updates-here
branch
from
f022f83
to
9182ec6
Compare
|
Rebased and fixed up some trailing "flavor" usage. |
workspaces/updater/updog/src/main.rs
Outdated
| @@ -336,6 +337,26 @@ fn update_flags() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// List any available update that matches the current flavor, ignoring waves | |||
| fn list_updates(manifest: &Manifest, flavor: &str, json: bool) -> Result<()> { | |||
There was a problem hiding this comment.
nit: It looks like the args in applicable_updates were updated to use variant, should this usage also then be updated to match?
Change the behaviour of check-update to not return any update unless the wave for the update that Updog is in is also ready. If no update is available or ready, Updog will now also return an error instead of succeeding silently. Signed-off-by: Samuel Mendoza-Jonas <samjonas@amazon.com>
sam-aws
force-pushed
the
no-updates-here
branch
from
9182ec6
to
a1d3bce
Compare
|
@jahkeup good catch, fixed up! |
Issue #, if available:
N/A
Description of changes:
Change the behaviour of check-update to not return any update unless the
wave for the update that Updog is in is also ready.
If no update is available or ready, Updog will now also return an error
instead of succeeding silently.
Signed-off-by: Samuel Mendoza-Jonas samjonas@amazon.com
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.