Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrony: Split chronyc into a subpackage #700

Merged
merged 1 commit into from
Feb 3, 2020
Merged

chrony: Split chronyc into a subpackage #700

merged 1 commit into from
Feb 3, 2020

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Jan 31, 2020

Issue #, if available: n/a

Description of changes:
Splits the chronyc binary into a chrony-tools subpackage, excluded in the aws-k8s variant and included in the aws-dev variant.

This drops the dependency on readline for the aws-k8s variant.

Testing done:
Built both variants. It and readline are now excluded from aws-k8s, and are still included in aws-dev.

Ran instances in a cluster, enabled the admin container on one and systemctl status chronyd shows chrony running, with Selected source 169.254.169.123.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming your further testing passes. You could also check chronyc in the dev AMI.

@iliana
Copy link
Contributor Author

iliana commented Feb 3, 2020

@tjkirch testing added :)

@iliana iliana merged commit 55c9a75 into develop Feb 3, 2020
@iliana iliana deleted the timesplitters branch February 4, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants