Include migration builds in image builds #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Feb 7, 2020
zmrow
force-pushed
the
make-migrations
branch
from
47c3996
to
e28edc3
Compare
|
Removed Ben's commit |
zmrow
force-pushed
the
make-migrations
branch
2 times, most recently
from
fddc726
to
5aa667e
Compare
|
Updated this to remove the This change rolls the migration logic into |
zmrow
changed the title
cargo make target that builds migrations
tjkirch
reviewed
Feb 7, 2020
jahkeup
suggested changes
Feb 7, 2020
zmrow
force-pushed
the
make-migrations
branch
2 times, most recently
from
efac087
to
9eb641b
Compare
|
Reworked this quite a bit.
|
bcressey
reviewed
Feb 12, 2020
zmrow
force-pushed
the
make-migrations
branch
from
9eb641b
to
7f117d5
Compare
|
Addressed @bcressey 's comments |
tjkirch
approved these changes
Feb 12, 2020
Comment on lines
+205
to
+206
| for version_path in %{_builddir}/workspaces/api/migration/migrations/*; do | ||
| for migration_path in "${version_path}"/*; do |
There was a problem hiding this comment.
nit: we should be consistent about quoting. (I don't like quoting paths containing globs, but if shellcheck complains, it's fine.)
This change includes migration builds with image builds. It will build all of the migrations, lz4 compress them, and tar them up as an output of the build.
zmrow
force-pushed
the
make-migrations
branch
from
7f117d5
to
9559bfc
Compare
|
Added contents of migrations artifact to description Addressed @tjkirch 's comments |
tjkirch
approved these changes
Feb 13, 2020
jahkeup
reviewed
Feb 13, 2020
jahkeup
reviewed
Feb 13, 2020
jahkeup
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related to #606
Description of changes:
This change includes migration builds with image builds. It
will build all of the migrations, strip them, lz4 compress them, and
tar them up as an output of the build.
Testing done:
cargo makeoutputs expected artifacts and migrationsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.