Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license-scan: Add Cargo.toml support #719

Merged
merged 3 commits into from
Feb 13, 2020
Merged

license-scan: Add Cargo.toml support #719

merged 3 commits into from
Feb 13, 2020

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Feb 11, 2020

Issue #, if available: #469

Description of changes:
license-scan now understands how to get a list of packages from a Cargo.toml and scan it for licenses.

There are now clarify.toml files for workspaces and license-scan.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@iliana
Copy link
Contributor Author

iliana commented Feb 11, 2020

@tjkirch this has an SDK bump, should we merge it into your pending rename branch instead of develop?

@tjkirch tjkirch mentioned this pull request Feb 12, 2020
@tjkirch
Copy link
Contributor

tjkirch commented Feb 12, 2020

@tjkirch this has an SDK bump, should we merge it into your pending rename branch instead of develop?

We discussed offline; we'll do an octopus merge and push that to close #722 and this, resolving the SDK update conflict in the merge. The SDK changes are unrelated and can go in together.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right to me, but it is fairly complex, so I requested a few comments. Would also be good to see some kind of example output in the PR description.

extras/sdk-container/Dockerfile Show resolved Hide resolved
extras/sdk-container/Dockerfile Show resolved Hide resolved
packages/release/release.spec Show resolved Hide resolved
workspaces/clarify.toml Outdated Show resolved Hide resolved
extras/sdk-container/license-scan/src/main.rs Show resolved Hide resolved
extras/sdk-container/license-scan/src/main.rs Show resolved Hide resolved
extras/sdk-container/license-scan/src/main.rs Outdated Show resolved Hide resolved
extras/sdk-container/license-scan/src/main.rs Outdated Show resolved Hide resolved
Co-Authored-By: Tom Kirchner <tjkirch@users.noreply.github.com>
Copy link

@ajorg-aws ajorg-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo my utter lack of Rust chops.

tjkirch added a commit that referenced this pull request Feb 13, 2020
@iliana iliana merged commit 2cf465e into develop Feb 13, 2020
@iliana iliana deleted the license-scan-rust branch February 13, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants