Add license metadata to first-party code #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliana
commented
Feb 18, 2020
|
|
||
| **Terms of contribution:** | ||
|
|
||
| By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license. |
There was a problem hiding this comment.
This particular verbiage needs to be added to the pull request template in our other repos.
samuelkarp
approved these changes
Feb 18, 2020
ajorg-aws
reviewed
Feb 18, 2020
ajorg-aws
reviewed
Feb 18, 2020
Comment on lines
+1
to
+2
| MIT License | ||
| Copyright Amazon.com, Inc., its affiliates, or other contributors. All Rights Reserved. |
There was a problem hiding this comment.
If I'm being precise, there should be a blank line between these two. Most likely any SPDX matching thing is still going to match it though.
ajorg-aws
reviewed
Feb 18, 2020
packages/util-linux/util-linux.spec
Outdated
Comment on lines
122
to
126
| mkdir -p %{buildroot}%{_cross_licensedir}/$lib | ||
| echo "$lib - %{url}" >> %{buildroot}%{_cross_licensedir}/$lib/attribution.txt | ||
| mkdir -p %{buildroot}%{_cross_licensedir}/%{_cross_os}$lib | ||
| echo "$lib - %{url}" >> %{buildroot}%{_cross_licensedir}/%{_cross_os}$lib/attribution.txt | ||
| done | ||
| echo "SPDX-License-Identifier: LGPL-2.1-or-later" | tee -a %{buildroot}%{_cross_licensedir}/lib{blkid,mount,smartcols}/attribution.txt >/dev/null | ||
| echo "SPDX-License-Identifier: BSD-3-Clause" | tee -a %{buildroot}%{_cross_licensedir}/libuuid/attribution.txt | ||
| echo "SPDX-License-Identifier: LGPL-2.1-or-later" | tee -a %{buildroot}%{_cross_licensedir}/%{_cross_os}lib{blkid,mount,smartcols}/attribution.txt >/dev/null | ||
| echo "SPDX-License-Identifier: BSD-3-Clause" | tee -a %{buildroot}%{_cross_licensedir}/%{_cross_os}libuuid/attribution.txt |
There was a problem hiding this comment.
These changes, and others in this file, look unrelated.
On the other hand, they are related to license metadata at least.
tjkirch
approved these changes
Feb 18, 2020
|
This most recent push replaces the last commit with one that removes the %{_cross_os} prefix from all the directories in /usr/share/licenses. @tjkirch |
tjkirch
approved these changes
Feb 19, 2020
bcressey
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#469
Description of changes:
This adds the top-level license files for Bottlerocket, sets the relevant metadata in the right places, and cleans up a few copyright-related things.
Non-nit requests for changes will likely need to go through a lawyer, so be careful what you wish for. :)
We somehow lost our pull request template in the move from the old repo, so it seemed the old file path wasn't working. This one might. Hard to test without merging (I copied and pasted it into this PR description).
Testing done:
An image builds. /usr/share/licenses (after mounting) looks fine.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.