Add 'set-migrations' subcommand to updata #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
commented
Feb 20, 2020
| @@ -80,6 +80,14 @@ pub struct Manifest { | |||
| pub datastore_versions: BTreeMap<SemVer, DataVersion>, | |||
| } | |||
|
|
|||
| #[derive(Debug, Default, Serialize, Deserialize)] | |||
| pub struct Release { | |||
There was a problem hiding this comment.
I'm not really keen on having this struct here, but it represents the best and easiest place to deal with ser/deserializing Release.toml data for now.
As we do a few more releases and get a better idea of how we're going to use this data I think it will move. But short-term, this will do the job.
tjkirch
approved these changes
Feb 20, 2020
This commit adds a 'set-migrations' subcommand to updata that will copy the migrations section from a file to another file. This subcommand replaces the `add-migration` and `remove-migration` subcommands. It is meant to be used to take migrations data from `Release.toml` and copy it to `manifest.json`.
zmrow
force-pushed
the
updata-set-migrations
branch
from
e6707d1
to
f0b614d
Compare
|
Add comment suggested by @tjkirch |
tjkirch
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This commit adds a 'set-migrations' subcommand to updata that will
copy the migrations section from a file to another file. This
subcommand replaces the
add-migrationandremove-migrationsubcommands. It is meant to be used to take migrations data from
Release.tomland copy it tomanifest.json.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.