INSTALL.md: add more detail and simplify userdata #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
force-pushed
the
samuelkarp/install_md
branch
from
a298760
to
63c0075
Compare
tjkirch
approved these changes
Feb 21, 2020
A few small changes to the installation instructions: * Be explicit about the dependencies of amiize.sh, as they may not be available by default in all environments * Update the root image file name in amiize.sh instructions * Specify the expected user-data format as an output template to `jq`, removing the need to manually-construct the file * Use `--cluster` for `eksctl` as `--name` is now deprecated
samuelkarp
force-pushed
the
samuelkarp/install_md
branch
from
63c0075
to
b1c0602
Compare
tjkirch
approved these changes
Feb 21, 2020
bcressey
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A few small changes to the installation instructions:
jq, removing the need to manually-construct the file--clusterforeksctlas--nameis now deprecatedTesting done:
Built an image, created an AMI, launched an instance into a cluster
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.