Rename built artifacts (variant-arch-version) #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
reviewed
Feb 25, 2020
|
Separate cleanup ask: can we relocate RPMs into It's jarring to see the two conventions side by side and the RPM naming convention is much harder to change. |
What if images (and migrations) remained in the main build directory? They're the primary output. [edit] or at least call the directory "images"? :) |
|
I like images/migrations in the |
Previously built artifacts were named as such: bottlerocket-$ARCH-$VARIANT-$VERSION-$COMMIT.extension This commit moves the $VARIANT first to better line up with names elsewhere in the project: bottlerocket-$VARIANT-$ARCH-VERSION-$COMMIT.extension
zmrow
force-pushed
the
rename-artifacts
branch
from
be37333
to
0ff455d
Compare
|
Addressed comments from @tjkirch |
bcressey
approved these changes
Feb 26, 2020
tjkirch
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Previously, all built artifacts were named as such:
bottlerocket-$ARCH-$VARIANT-$VERSION-$COMMIT.extensionThis commit moves the
$VARIANTfirst to better line up withnames elsewhere in the project:
bottlerocket-$VARIANT-$ARCH-VERSION-$COMMIT.extensionTesting done:
Images:
Migrations
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.