Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log migration errors at error level so they show on console #795

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Feb 27, 2020

Description of changes:

Pipes through the stderr from migrations so it's easier to debug upgrade/downgrade failures from using the console.

Testing done:

Normal:

20:48:23 [DEBUG] (1) migrator: Migration stdout: Found no settings.added to remove
20:48:23 [DEBUG] (1) migrator: No migration stderr

With a dbg! in a migration so it has stderr:

20:48:36 [DEBUG] (1) migrator: Migration stdout: Found no settings.timezone to remove
20:48:36 [ERROR] Migration stderr: [api/migration/migration-helpers/src/lib.rs:93] &args.source_datastore = "/home/ANT.AMAZON.COM/tjk/work/thar/sources/api/migration/migrator/datastore-sample/v0.2.3_Ntp8bK3jHO8fkuRr"

@tjkirch tjkirch requested review from zmrow and webern February 27, 2020 20:52
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@tjkirch tjkirch changed the title Log migration errors to at error level so they show on console Log migration errors at error level so they show on console Feb 28, 2020
@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 28, 2020

This push just fixes a typo in the commit subject.

@tjkirch tjkirch merged commit 93d97a4 into develop Feb 28, 2020
@tjkirch tjkirch deleted the migrator-stderr branch February 28, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants