Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUICKSTART: add section on finding AMIs through SSM parameters #838

Merged
merged 1 commit into from
Mar 10, 2020
Merged

QUICKSTART: add section on finding AMIs through SSM parameters #838

merged 1 commit into from
Mar 10, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Mar 10, 2020

Testing done:

Rendered through grip and here, ran the commands.

jahkeup
jahkeup reviewed Mar 10, 2020
View reviewed changes
QUICKSTART.md Show resolved Hide resolved
jhaynes
jhaynes approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@jhaynes jhaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go for now, but we should revisit and potentially include the full output like @jahkeup suggested.

zmrow
zmrow approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌲

@tjkirch
Copy link
Contributor Author

tjkirch commented Mar 10, 2020

This push adds a basic form of the SSM command that doesn't use jq, and a more advanced form with jq that now also gives the time the parameter was updated.

jahkeup
jahkeup approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tjkirch
Copy link
Contributor Author

tjkirch commented Mar 10, 2020

This push replaces the jq localtime call with gmtime which is compatible with jq 1.5.

jahkeup
jahkeup approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌚

@tjkirch tjkirch merged commit f1c1d23 into develop Mar 10, 2020
@tjkirch tjkirch deleted the ssm-param branch March 10, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliana iliana iliana approved these changes

@jahkeup jahkeup jahkeup approved these changes

@jhaynes jhaynes jhaynes approved these changes

@zmrow zmrow zmrow approved these changes

@etungsten etungsten etungsten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tjkirch @iliana @jahkeup @jhaynes @zmrow @etungsten