build: Pass proxy environment variables through to docker containers. #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building behind a proxy, build via 'cargo make' worked up to the point of 'running Task: fetch-vendored' where it hung. The reason was because necessary proxy environment variables were not passed into the docker container's environment. The fix here is to add these variables to the environment of the docker container if they are set outside the container: http_proxy, https_proxy, no_proxy
smoser
force-pushed
the
fix/proxy-to-docker
branch
from
c00cf05
to
47d34bf
Compare
etungsten
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: none
Description of changes:
When building behind a proxy, build via 'cargo make' worked up to
the point of 'running Task: fetch-vendored' where it hung.
The reason was because necessary proxy environment variables
were not passed into the docker container's environment.
The fix here is to add these variables to the environment of the
docker container if they are set outside the container:
http_proxy, https_proxy, no_proxy
Testing done: build with
cargo makeTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.