Add parse-datetime crate #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Mar 27, 2020
bcressey
reviewed
Mar 27, 2020
|
Rebased on |
bcressey
approved these changes
Mar 27, 2020
|
⌛️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #596
Description of changes:
As part of the issue above, we'd like to have a few files that define some default update wave structures. In those files, we'd like to use the nice interface for dates as tuftool uses. It's nice to type out
'in 7 days'rather than the full RFC3339 date.This crate doesn't contain any new code (except for the few tests); it's pulled from
tuftoolfor now as I'd rather not depend ontuftooljust for this specific functionality (it's notpubanyway). We can decide at a later time if we would like to publish this crate.Testing done:
All unit tests pass.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.