Add default wave files #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
approved these changes
Mar 27, 2020
|
Fixes the typo @webern caught. |
sam-aws
approved these changes
Mar 30, 2020
tjkirch
reviewed
Mar 30, 2020
|
After much discussion, we've decided to change the format of these files. Given the amount of discussion/confusion it made sense for us to make these files more user friendly and NOT to require any knowledge of the inner workings of The new format will be as follows and additional documentation of the format is included in the README.md. |
tjkirch
approved these changes
Apr 2, 2020
|
Updated to address @tjkirch 's comments |
tjkirch
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to #596
Description of changes:
Adds default wave files, an associated
README.mdand updates theREADME.mdinupdater/to refer to these new files.Testing done:
Rendered the READMEs.
Validated all TOML .
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.