containerd: reduce logging when no errors have occurred #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjkirch
approved these changes
Apr 2, 2020
etungsten
approved these changes
Apr 2, 2020
samuelkarp
approved these changes
Apr 2, 2020
packages/containerd/0001-reduce-logging-when-no-errors-have-occurred.patch
Outdated
Show resolved
Hide resolved
bcressey
approved these changes
Apr 3, 2020
|
🌲 |
samuelkarp
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #872
Description of changes:
Changes the logging verbosity level of non-exceptional, non-informative logs that were increasing the size of the system journal.
Here is a diff of what the patch is doing in
containerd(since diff of a diff can be hard to read).Testing done:
Ran an instance and observed that we are no longer receiving the logs mention in #872
Ran a simple pod.
Ran Sonobuoy tests which passed:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.