Admin container v0.5.0 migration

[etungsten]

commit 8c0aadfbb39461bf41da9e2a8511d1f084f355ba
Author: Erikson Tung <etung@amazon.com>
Date:   Tue Apr 14 14:52:31 2020 -0700

    migrations: add migration to migrate admin container version

    Adds a new migration to migrate the default admin host-container version
    from v0.4.0 to v0.5.0.

Issue number:
Addresses #890

Testing done:
Created a datastore locally using storewolf and manually populated settings.aws.region with "us-west-2"
Forward migration:

     Running `migrate-admin-container --source-datastore /tmp/ds/next --target-datastore /tmp/ds/current --forward`
Updating template and value of 'settings.host-containers.admin.source' on upgrade
Changing template of 'settings.host-containers.admin.source' from '328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.4.0' to '328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.5.0'
Changing value of 'settings.host-containers.admin.source' from '328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.4.0' to '328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.5.0'

$ cat /tmp/ds/current/live/settings/host-containers/admin/source.template
"328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.5.0"
$ cat /tmp/ds/current/live/settings/host-containers/admin/source
"328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.5.0"

Backwards migration:

     Running `migrate-admin-container --source-datastore /tmp/ds/current --target-datastore /tmp/ds/next --backward`
Updating template and value of 'settings.host-containers.admin.source' on downgrade
Changing template of 'settings.host-containers.admin.source' from '328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.5.0' to '328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.4.0'
Changing value of 'settings.host-containers.admin.source' from '328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.5.0' to '328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.4.0'

$ cat /tmp/ds/next/live/settings/host-containers/admin/source.template 
"328549459982.dkr.ecr.{{ settings.aws.region }}.amazonaws.com/bottlerocket-admin:v0.4.0"
$ cat /tmp/ds/next/live/settings/host-containers/admin/source
"328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.4.0"

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

[etungsten]

Force push above adds missing license information.

[tjkirch]

Sorry about needing the revert :(

[etungsten]

Addresses @tjkirch 's comments.

Checking why github actions is failing...

[etungsten]

The build check is failing because rpm2migrations is trying to install bottlerocket-x86_64-migrations-debuginfo-0.0-0.x86_64.rpm which has a dependency on bottlerocket-x86_64-os-debuginfo(x86-64) which it was not able to find and install...

bottlerocket/tools/rpm2migrations

Line 22 in 8af7e0a

rpm -iv --root "${ROOT_TEMP}" "${PACKAGE_DIR}"/*.rpm

In any case, rpm2migrations shouldn't be installing every single rpm that's built. It should really only need to install the ones needed by the main migrations rpm (currently has no dependencies, so just the migrations rpm).

We could also fix this by updating os.spec to strip the binaries with install -s (currently it's not stripping the migrations binaries which results in an migrations-debuginfo package):

bottlerocket/packages/os/os.spec

Lines 215 to 218 in 8af7e0a

	built_path="${HOME}/.cache/%{__cargo_target_static}/release/${crate_name}"
	target_path="%{buildroot}%{_cross_datadir}/migrations/${migration_binary_name}"
	install -m 0555 "${built_path}" "${target_path}"

[tjkirch]

@etungsten The Dockerfile sets it up so that only the migration rpm is in the packages directory when rpm2migrations is run - see the repobuild section. I think the problem is that what's copying the RPM into /local/migrations, namely the migrationbuild section, is using a "*" after "migration" so that it doesn't have to worry about every single component of the RPM's filename, and that unfortunately captures the debuginfo RPM too. I think we need to make the filename pattern in the cp more exact.

I'm not sure why this would have changed...

[zmrow]

Hm... this change in behavior seems... odd. I don't recall seeing this issue when putting together rpm2migrations.

[etungsten]

Push above removes the direct dependency listing on schnauzer.

I'll fix the build issue in a separate PR.

[tjkirch]

LGTM, but we shouldn't approve/merge until we know we can build migrations safely again.

Perhaps the revert of the WrappedSettings change should also go into the other PR related to fixing the build?

[etungsten]

Rebased on develop to get migration build fix.

[zmrow]

🌺