Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: Apply patches for CVE-2020-8558 #977

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

samuelkarp
Copy link
Contributor

Description of changes:
Apply patches for CVE-2020-8558

Testing done:
Built both aws-k8s-1.15 and aws-k8s-1.16 variants. Have not yet run Sonobuoy tests.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged #973, so you could include the patch for 1.17 here too; it'd probably be good to keep them together.

@samuelkarp
Copy link
Contributor Author

It looks like the fix is already present in the version of 1.17 that you packaged (1.17.8), so there's no additional work needed.

Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonobuoy test results came back fine:

1.15:

 PLUGIN     STATUS   RESULT   COUNT
            e2e   complete   passed       1
   systemd-logs   complete   passed       3

Sonobuoy has completed. Use `sonobuoy retrieve` to get results.
Plugin: e2e
Status: passed
Total: 4412
Passed: 215
Failed: 0
Skipped: 4197

Plugin: systemd-logs
Status: passed
Total: 3
Passed: 3
Failed: 0
Skipped: 0

1.16:

PLUGIN     STATUS   RESULT   COUNT
            e2e   complete   passed       1
   systemd-logs   complete   passed       3

Sonobuoy has completed. Use `sonobuoy retrieve` to get results.
Plugin: systemd-logs
Status: passed
Total: 3
Passed: 3
Failed: 0
Skipped: 0

Plugin: e2e
Status: passed
Total: 4732
Passed: 276
Failed: 0
Skipped: 4456

@tjkirch tjkirch added this to the v0.4.1 milestone Jul 9, 2020
@samuelkarp samuelkarp merged commit d58225f into bottlerocket-os:develop Jul 9, 2020
@samuelkarp samuelkarp deleted the cve-2020-8558 branch July 9, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants