New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create bottle crashing if no Nvidia GPU and NVAPI installs #2607
Conversation
Pylint result on modfied files:
|
Should I able to run this fix with this github action? https://github.com/bottlesdevs/Bottles/actions/runs/3979230456
|
Ah I made an oopsie, I will fix it later, sorry. When it is fixed, you'll be able to use it |
Creating bottle, opening location and deleting it seems to work now. Here's terminal output:
|
Perfect, thanks for your testing! |
I probably stumbled upon another problem. Don't know if it's because of this version, but it's first time I've seen anything like that. I had trouble running the game from custom path so I tested my known 2 cases being PK2 and Notepad++. They work, but they also don't appear in bottle.yml unless you rename them (one of my unanswered questions in Bottles github). I also found a game that doesn't install because it wants to install in Z: drive and when you add the installer to the programs list manually it has this path in bottle.yml I can reinstall Bottles now if you want me to check it in normal 50.2 version, but then it's possible I won't have the current problem anymore and won't be able to test this version. |
It looks like another error, probably wrong flatpak permissions I would say. Please open a new issue! |
Description
For some reasons, sometimes NVAPI wants to be installed even though the user doesn't have an Nvidia GPU. This PR adds another check to see if a DLL exists before check/install/uninstall. Also, a check to see if the user has a Nvidia card when creating a Bottle was implemented. This does not fix all occurences of the behavior, like for example when importing an existing Bottle, but it's a start.
Fixes #2594
For reviewers to test: when not using a Nvidia card, create a bottle. You should not have any indication of NVAPI being installed.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.