Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting modularization v2 #391

Conversation

korczis
Copy link
Contributor

@korczis korczis commented Apr 18, 2015

Brief

This is first of two step steps which will modularize voting.js

Details

Step #1

  • Create module

Step #2

  • Move voting.js code to module
  • Use constanst from config.js
  • Add tests

@botwillacceptanything
Copy link
Owner

☑️ Voting procedure reminder:

To cast a vote, post a comment containing 👍:+1:, or 👎:-1:.
Remember, you must ⭐star this repo for your vote to count.

All comments within this discussion are searched for votes, regardless of the time of posting.
You can cast as many votes as you want, but only the last one will be counted.
(You may consider editing your comment instead of adding a new one.)
Comments containing both 👍up- and 👎down-votes are disregarded.
Comments containing monkeys are disregarded. 🐒 🐵 🙈 🙉 🙊
PR authors automatically count as a 👍 vote.

A decision will be made after this PR has been open for 15 minutes (plus/minus 10 percent, to avoid people timing their votes), and at least 8 votes have been made.
A supermajority of 65% is required for the vote to pass.

NOTE: the PR will be closed if any new commits are added after:
c85ff69

@coveralls
Copy link

Coverage Status

Coverage increased (+0.16%) to 27.72% when pulling c85ff69 on korczis:voting-modularization-v2 into d682e7c on botwillacceptanything:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.16%) to 27.72% when pulling c85ff69 on korczis:voting-modularization-v2 into d682e7c on botwillacceptanything:master.

@dbpokorny
Copy link
Contributor

👍 curious what "modularize" means in this context...guess I'll have to wait until the next step to find out

@SpenserJ
Copy link
Contributor

👍

3 similar comments
@ghost
Copy link

ghost commented Apr 18, 2015

👍

@timweightman
Copy link
Contributor

👍

@thenightwassave
Copy link
Contributor

👍

@botwillacceptanything
Copy link
Owner

👍 The vote passed! This PR will now be merged into master.


Tallies:
👍: 6 (100%)
👎: 0 (0%)

These users aren't stargazers, so their votes were not counted:

botwillacceptanything added a commit that referenced this pull request Apr 18, 2015
@botwillacceptanything botwillacceptanything merged commit b593b14 into botwillacceptanything:master Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants