Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken conversationsystem for muting the bot #394

Merged
merged 2 commits into from
Apr 19, 2015

Conversation

Prior99
Copy link
Contributor

@Prior99 Prior99 commented Apr 18, 2015

No description provided.

@botwillacceptanything
Copy link
Owner

☑️ Voting procedure reminder:

To cast a vote, post a comment containing 👍:+1:, or 👎:-1:.
Remember, you must ⭐star this repo for your vote to count.

All comments within this discussion are searched for votes, regardless of the time of posting.
You can cast as many votes as you want, but only the last one will be counted.
(You may consider editing your comment instead of adding a new one.)
Comments containing both 👍up- and 👎down-votes are disregarded.
Comments containing monkeys are disregarded. 🐒 🐵 🙈 🙉 🙊
PR authors automatically count as a 👍 vote.

A decision will be made after this PR has been open for 15 minutes (plus/minus 10 percent, to avoid people timing their votes), and at least 8 votes have been made.
A supermajority of 65% is required for the vote to pass.

NOTE: the PR will be closed if any new commits are added after:
8d0c191

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 27.71% when pulling 8d0c191 on Prior99:master into b593b14 on botwillacceptanything:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 27.71% when pulling 8d0c191 on Prior99:master into b593b14 on botwillacceptanything:master.

@dos1
Copy link
Contributor

dos1 commented Apr 18, 2015

get lost @coveralls
👍

@shalecraig
Copy link
Contributor

Failing coveralls? ruh roh.

👍

@shalecraig
Copy link
Contributor

Actually, 👎

  • Please remove MOOD_THRESHOLD if it's no longer used.
  • Please remove initiateNeutralConversation if it's no longer used.
  • Please use both mute() and unmute(), or emit("mute") and emit("unmute"). Mixing and matching both makes it hard to see what's actually going on, and introduces the opportunity for you to forget to update things.

@dbpokorny
Copy link
Contributor

👍

3 similar comments
@SpenserJ
Copy link
Contributor

👍

@thenightwassave
Copy link
Contributor

👍

@OLef1air
Copy link
Contributor

👍

@botwillacceptanything
Copy link
Owner

👍 The vote passed! This PR will now be merged into master.


Tallies:
👍: 6 (85.7%)
👎: 1 (14.2%)

These following 1 voter(s) were not stargazers, so their votes were not counted:

Be sure to ⭐star the repository if you want to have your say!

botwillacceptanything added a commit that referenced this pull request Apr 19, 2015
Fix broken conversationsystem for muting the bot
@botwillacceptanything botwillacceptanything merged commit 4bd90b4 into botwillacceptanything:master Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants