Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting modularization v2 #395

Closed

Conversation

korczis
Copy link
Contributor

@korczis korczis commented Apr 18, 2015

No description provided.

@botwillacceptanything
Copy link
Owner

☑️ Voting procedure reminder:

To cast a vote, post a comment containing 👍:+1:, or 👎:-1:.
Remember, you must ⭐star this repo for your vote to count.

All comments within this discussion are searched for votes, regardless of the time of posting.
You can cast as many votes as you want, but only the last one will be counted.
(You may consider editing your comment instead of adding a new one.)
Comments containing both 👍up- and 👎down-votes are disregarded.
Comments containing monkeys are disregarded. 🐒 🐵 🙈 🙉 🙊
PR authors automatically count as a 👍 vote.

A decision will be made after this PR has been open for 15 minutes (plus/minus 10 percent, to avoid people timing their votes), and at least 8 votes have been made.
A supermajority of 65% is required for the vote to pass.

NOTE: the PR will be closed if any new commits are added after:
2871dc5

@timweightman
Copy link
Contributor

👍 This is a great looking change. Very testable! :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.97%) to 26.76% when pulling a9ddad5 on korczis:voting-modularization-v2 into b593b14 on botwillacceptanything:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.97%) to 26.76% when pulling a9ddad5 on korczis:voting-modularization-v2 into b593b14 on botwillacceptanything:master.

@korczis
Copy link
Contributor Author

korczis commented Apr 18, 2015

@timweightman thank you. Make it testable is my motivation.

@botwillacceptanything
Copy link
Owner

⚠️ This PR has been modified and is now being closed.

To prevent people from sneaking in changes after votes have been made, pull requests can't be committed on after they have been opened. Feel free to open a new PR for the proposed changes to start another round of voting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants