Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter not double tweet #401

Conversation

shalecraig
Copy link
Contributor

Re-rolling #400

Noticed this bug. Fixed this bug. https://twitter.com/anythingbot

It's kindof bad that we duplicate this logic everywhere, but ¯\_(ツ)_/¯

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 27.78% when pulling caa4eb9 on shalecraig:twitter-not-double-tweet into 24fccf0 on botwillacceptanything:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 27.78% when pulling caa4eb9 on shalecraig:twitter-not-double-tweet into 24fccf0 on botwillacceptanything:master.

@botwillacceptanything
Copy link
Owner

☑️ Voting procedure reminder:

To cast a vote, post a comment containing 👍:+1:, or 👎:-1:.
Remember, you must ⭐star this repo for your vote to count.

All comments within this discussion are searched for votes, regardless of the time of posting.
You can cast as many votes as you want, but only the last one will be counted.
(You may consider editing your comment instead of adding a new one.)
Comments containing both 👍up- and 👎down-votes are disregarded.
Comments containing monkeys are disregarded. 🐒 🐵 🙈 🙉 🙊
PR authors automatically count as a 👍 vote.

A decision will be made after this PR has been open for 15 minutes (plus/minus 10 percent, to avoid people timing their votes), and at least 8 votes have been made.
A supermajority of 65% is required for the vote to pass.

NOTE: the PR will be closed if any new commits are added after:
caa4eb9

@botwillacceptanything
Copy link
Owner

👎

@SpenserJ
Copy link
Contributor

I'd prefer that we used var mockMergeEvent = _.merge({}, mockEvent, { merged_at: '2011-01-26T19:01:12Z' }), so that we always have the same base event. 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants