Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown for voting ended comment. (updated) #407

Merged
merged 1 commit into from
Apr 19, 2015
Merged

Use markdown for voting ended comment. (updated) #407

merged 1 commit into from
Apr 19, 2015

Conversation

timweightman
Copy link
Contributor

No description provided.

@botwillacceptanything
Copy link
Owner

☑️ Voting procedure reminder:

To cast a vote, post a comment containing 👍:+1:, or 👎:-1:.
Remember, you must ⭐star this repo for your vote to count.

All comments within this discussion are searched for votes, regardless of the time of posting.
You can cast as many votes as you want, but only the last one will be counted.
(You may consider editing your comment instead of adding a new one.)
Comments containing both 👍up- and 👎down-votes are disregarded.
Comments containing monkeys are disregarded. 🐒 🐵 🙈 🙉 🙊
PR authors automatically count as a 👍 vote.

A decision will be made after this PR has been open for 15 minutes (plus/minus 10 percent, to avoid people timing their votes), and at least 8 votes have been made.
A supermajority of 65% is required for the vote to pass.

NOTE: the PR will be closed if any new commits are added after:
e3df13e

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 27.79% when pulling e3df13e on timweightman:voting-ended-markdown into 24fccf0 on botwillacceptanything:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 27.79% when pulling e3df13e on timweightman:voting-ended-markdown into 24fccf0 on botwillacceptanything:master.

@samis
Copy link
Contributor

samis commented Apr 18, 2015

Good use of templating. 👍

@avdg
Copy link
Contributor

avdg commented Apr 18, 2015

👍

@timweightman
Copy link
Contributor Author

Thanks @samis!

@dos1
Copy link
Contributor

dos1 commented Apr 18, 2015

👍

@SpenserJ
Copy link
Contributor

Why Markdown instead of Handlebars, like we have in the rest of the site?

@dos1
Copy link
Contributor

dos1 commented Apr 19, 2015

It's actually just a misnamed PR. Markdown isn't a templating system.

@dbpokorny
Copy link
Contributor

👍

1 similar comment
@OLef1air
Copy link
Contributor

👍

@botwillacceptanything
Copy link
Owner

👍 The vote passed! This PR will now be merged into master.


Tallies:
👍: 6 (100%)
👎: 0 (0%)

These users aren't stargazers, so their votes were not counted:

botwillacceptanything added a commit that referenced this pull request Apr 19, 2015
Use markdown for voting ended comment. (updated)
@botwillacceptanything botwillacceptanything merged commit 6768b85 into botwillacceptanything:master Apr 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants