Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some ISO-2 langcodes #219

Closed
wants to merge 1 commit into from
Closed

Fix some ISO-2 langcodes #219

wants to merge 1 commit into from

Conversation

ojdo
Copy link

@ojdo ojdo commented Jan 31, 2023

Align imports with real langcodes used in spacy.lang: https://github.com/explosion/spaCy/tree/master/spacy/lang

@ojdo
Fix some ISO-2 langcodes
8109c1c 
Align imports with real langcodes used in spacy.lang:
https://github.com/explosion/spaCy/tree/master/spacy/lang
@ojdo
Copy link
Author

ojdo commented Jan 31, 2023

Partial overlaps with #215, #216, and same topic but no overlap with #191.

ygorg added a commit to ygorg/pke that referenced this pull request Mar 15, 2023
@ygorg
Fixed ISO-2 langcode (from boudinfl#191 boudinfl#215, boudinfl#216, b…
ba14006 
…oudinfl#219) and clarified current supported languages.
@ygorg ygorg mentioned this pull request Mar 15, 2023
Merged
@ygorg
Copy link
Collaborator

ygorg commented Mar 15, 2023

Thank you so much your PR !
The way languages are used in pke should more precise (and the langcodes right ;)
#225 fixes these issues

@ygorg ygorg closed this Mar 15, 2023
ygorg added a commit that referenced this pull request Mar 15, 2023
@ygorg
Consolidate lang usage in pke (#225)
f2d4f5d 
* Fixed `TypeError` when language is not supported by pke

* Fixed ISO-2 langcode (from #191 #215, #216, #219) and clarified current supported languages.

* Clarified warning and exceptions when loading a document.

* Raise exception if language is not an iso2 langcode
@ygorg ygorg mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ojdo @ygorg