fix empty attr value in legacy input

bougassaa · Dec 21, 2022 · cc33501 · cc33501
1 parent f11360a
commit cc33501
Show file tree

Hide file tree

Showing 3 changed files with 57 additions and 57 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-to-html-element",
-  "version": "1.4.6",
+  "version": "1.4.7",
   "description": "Converts React Components to HTML Element (also known as Web Component, Custom Element)",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -14,16 +14,16 @@ const handleValueAttr = (children) => {
         if (typeof child.props === "object") {
             child = {...child};
             child.props = {...child.props}
-        }
 
-        if (['input', 'textarea', 'select'].indexOf(child.type) >= 0 && child?.props?.value) {
-            child.props.defaultValue = child.props.value;
-            delete child.props.value;
-        }
+            if (['input', 'textarea', 'select'].indexOf(child.type) >= 0 && Object.hasOwn(child.props, 'value')) {
+                child.props.defaultValue = child.props.value;
+                delete child.props.value;
+            }
 
-        if (child?.props?.children) {
-            let c = Array.isArray(child.props.children) ? child.props.children : [child.props.children];
-            child.props.children = handleValueAttr(c);
+            if (child.props?.children) {
+                let c = Array.isArray(child.props.children) ? child.props.children : [child.props.children];
+                child.props.children = handleValueAttr(c);
+            }
         }
 
         return child;