Build: add missing files in the Makefile for Mingw #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the long delay. Can I have a "Signed-off-by"? |
|
@tkisky for sure |
|
Can you show how you'd like it to read ? |
|
@tkisky sorry, I don't understand what you mean. To read what? What should I show? |
|
ie. Signed-off-by: Joe Canfoderiskii joe.canfoderiskii@gmail.com |
|
@tkisky Just do whatever you like, is it okay? I don't wanna expose my real name and email address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some modification in Makefile.mingw.
For my personal usage, I also changed the
MINGW32toMINGW64for linking with the objects generated by mingw-w64 toolchain in MSYS2 environment.But in this pull request, I leave the
MINGW32unchanged.Maybe it's a good idea that to add one more variable for 32-bit or 64bit selection.