Improved user registration, update and view profile APIs (resolves #204) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2021 13:47
… view, improved the user model and the serializer, new and improved registration api
ege-kaya
requested review from
ibrahimbayat
and removed request for
KeremZaman
ibrahimbayat
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have improved the profile view controller to inherit the Django Rest Framework's RetrieveAPIView class, resulting in a better and cleaner implementation. I have also implemented the profile update view, but as of right now it does not check whether the request for the update comes from the correct user. I will now look into the user identification and authorization using the JWT token architecture we set up. I have implemented the user identification and permission-checking part of the profile update API as well.