Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events with activitystream (resolves #213) #218

Merged
merged 9 commits into from
Dec 10, 2021
Merged

Events with activitystream (resolves #213) #218

merged 9 commits into from
Dec 10, 2021

Conversation

ege-kaya
Copy link
Collaborator

@ege-kaya ege-kaya commented Dec 9, 2021

I have edited the create event and get event APIs to return ActivityStream-compliant JSON responses.

ege-kaya added 8 commits December 2, 2021 23:48
initializing django activity streams to use with event posts (hopefully)
f5fabf7
reimplemented the event views, create event now checks correctness of…
995a4bc 
… the owner field, registered the eventpost and user models for use with activitystream
viewing profile returns avatar
63856ba
profile update and profile get run on the same endpoint now, with met…
1106cb7 
…hods PUT and GET
worked on createevent api to make it activitystream compliant
df42ba1
get event and create event methods now return activitystream complian…
7b340ae 
…t json responses
fixed a small bug causing spectators to always return empty, added th…
d5a04ae 
…e field applicants to the eventposts model, fixed default array values to use callables
fixed a small bug causing spectators to always return empty, added th…
9d1aefa 
…e field applicants to the eventposts model, fixed default array values to use callables
ibrahimbayat
ibrahimbayat approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@ibrahimbayat ibrahimbayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is appropriate for the activity stream, and working with ViewSet, it includes all get, post etc functions.

KeremZaman
KeremZaman approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@KeremZaman KeremZaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine, thanks for adapting current system to work with activity stream!

@ege-kaya ege-kaya merged commit 024c5f8 into development Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeremZaman KeremZaman KeremZaman approved these changes

@ibrahimbayat ibrahimbayat ibrahimbayat approved these changes

@supiket supiket Awaiting requested review from supiket

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ege-kaya @KeremZaman @ibrahimbayat