Configure GH Actions for running tests before merging into development branch #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 12, 2021 16:52
- Add filtering by query, player capacity, spectators capacity, number of players, number of spectators, location name, event date, creation date, duration of the event, sport type, event owner, age, coordinates, skill levels - Make relative imports absolute
- Add unittests for event search functionality - Configure test database - Convert relative imports to absolute imports in serializers.py
- Add testing command to run tests before starting application - Add wait_for_db script for backend service to wait until database is ready
test_filter_by_date was failing due to the default value of the date field in EventPost model. By quoting the related part about auto_now_add from django documentation: " So even if you set a value for this field when creating the object, it will be ignored." Since the dates specified for the sample events created for tests were ignored, date_by_filter test was failing. This bug would cause wrong event dates while user creating an event, it is fixed by changing default value to the time of the event creation.
- Add Github workflow to configure tests, set pushing to current branch as trigger for now - Configure test database for Github workflow
…rse it as python 3.1
The default working directory is already backend folder
berkaydoner
approved these changes
Dec 13, 2021
supiket
approved these changes
Dec 13, 2021
| many=True).data | ||
|
|
||
| self.skill_between_2_4 = self.football_games | ||
|
|
There was a problem hiding this comment.
The test coverage looks great, I see pretty exhaustive tests here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please do not merge this request before PR #231 is merged because this branch is created from eventposts-search.