Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android view event merge request #258

Merged
merged 9 commits into from
Dec 24, 2021
Merged

Android view event merge request #258

merged 9 commits into from
Dec 24, 2021

Conversation

Voursstrreds
Copy link
Collaborator

New features of the program is added.

Cannot automatically merge right now due to the changes. Change those consistently and review the code.

Main activity is changed to adopt new detailed view of events feature.
View all event fragment is changed.
View event detailed fragment is added.
Card view fragment xml file is changed, added a detailed button.
View event detailed fragment xml file is added.
card_view is renewed.
@Voursstrreds
Copy link
Collaborator Author

Conflicts were resolved.
It is ready to review.

Copy link
Collaborator

@ibrahimbayat ibrahimbayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the code. It seems good to me as far as I understand. But of course reviews from android members will be more beneficial.

@Voursstrreds Voursstrreds merged commit 082b39d into android Dec 24, 2021
@Voursstrreds Voursstrreds deleted the android-view-event branch December 24, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants