Applying to event functionality #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 26, 2021 12:54
- Add API endpoint for applying to an event as spectator or player - Add age and capacity checks for applicants - Add API endpoint for accepting or rejecting applicants for an event by owner of the event - Add capacity check while accepting applicants - Change Eventpost model to have 2 different fields for spectator applicants and player applicants
- Add tests for applying as player or spectator, applying in full capacity situations, applying when not qualified for the event, accepting player or spectator, rejecting player or spectator, accepting in full capacity scenarios and fetching applicant list
CenekSanzak
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
I reviewed the API documentation you provided. I think it is functional for our purpose but you should add the returned object to the API documentation when you are creating a wiki page for it. I reviewed your code but I didn't run it, I think that it is implemented well.
ibrahimbayat
approved these changes
Dec 26, 2021
There was a problem hiding this comment.
I think it is a well written code, and includes player and spectator applications. Also, users are removed from the applicants then added to the participants and necessary checks are done before adding users to participant list. But maybe returning responses can be written in to the documentation and it can be written according to activity stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented event application functionality. Current API endpoint is given under Issue #275 , please review it as well as the code.