-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equipment posts API (resolves #268) #292
Conversation
…pp. also fixed a bug in the wrapper classes for eventposts and equipmentposts, slightly changed the models and other small tweaks
added migration for equipmentposts app
default user birthday is 18 years before today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments and requested some changes about the parts that are redundant I guess . Also, I commented on some parts that need clarifications.
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it seems okay. Thanks for your effort, great work!
I have implemented the equipment posts API, working in the way indicated in the API documentation and with Activity Streams responses. There was a problem with the last pull request, it should hopefully be fixed now. It also now runs in a separate Django app from eventposts. Please review and give me any necessary feedback