Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment posts API (resolves #268) #292

Merged
merged 16 commits into from
Dec 30, 2021
Merged

Conversation

ege-kaya
Copy link
Collaborator

I have implemented the equipment posts API, working in the way indicated in the API documentation and with Activity Streams responses. There was a problem with the last pull request, it should hopefully be fixed now. It also now runs in a separate Django app from eventposts. Please review and give me any necessary feedback

…pp. also fixed a bug in the wrapper classes for eventposts and equipmentposts, slightly changed the models and other small tweaks
@ege-kaya ege-kaya linked an issue Dec 29, 2021 that may be closed by this pull request
Copy link
Collaborator

@KeremZaman KeremZaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments and requested some changes about the parts that are redundant I guess . Also, I commented on some parts that need clarifications.

backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/equipmentposts/views.py Outdated Show resolved Hide resolved
backend/eventposts/views.py Show resolved Hide resolved
ege-kaya and others added 6 commits December 30, 2021 13:43
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Co-authored-by: Kerem Zaman <KeremZaman@users.noreply.github.com>
Copy link
Collaborator

@KeremZaman KeremZaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it seems okay. Thanks for your effort, great work!

@ege-kaya ege-kaya merged commit 1fab30e into development Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] API for equipment posts
2 participants