-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badges API #297
Badges API #297
Conversation
…context. added URLS to the fixture file for the initial badge data. get badge by name and get all badges APIs now work exactly as documented on the wiki.
… badges functionality
# Conflicts: # backend/app/settings.py # backend/app/urls.py # backend/profiles/views.py
…also removed every redundant import.
…into development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Badge API seems fine. Endpoints follow the activity stream formats we decided earlier and I did not notice any mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A clear implementation for badges feature. I left some comments about my concerns.
I haven't reviewed since the last year, sorry for any mistakes :)
All endpoints of the badges API should now be working as documented on the wiki. Happy new year! (resolves issue #269)