Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges API #297

Merged
merged 14 commits into from
Jan 1, 2022
Merged

Badges API #297

merged 14 commits into from
Jan 1, 2022

Conversation

ege-kaya
Copy link
Collaborator

All endpoints of the badges API should now be working as documented on the wiki. Happy new year! (resolves issue #269)

@ege-kaya ege-kaya linked an issue Dec 31, 2021 that may be closed by this pull request
Copy link
Collaborator

@berkaydoner berkaydoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badge API seems fine. Endpoints follow the activity stream formats we decided earlier and I did not notice any mistakes.

Copy link
Collaborator

@KeremZaman KeremZaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clear implementation for badges feature. I left some comments about my concerns.

I haven't reviewed since the last year, sorry for any mistakes :)

backend/authentication/models.py Show resolved Hide resolved
backend/badges/models.py Show resolved Hide resolved
backend/badges/tests.py Show resolved Hide resolved
@ege-kaya ege-kaya merged commit 7cb650c into development Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Database adjustments and API for badges
3 participants