-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Comments/answers API #309
Conversation
# Conflicts: # backend/equipmentposts/views.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review urls.py
, views.py
and tests.py
for event posts and equipment posts at a later time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good. Implementation is little different from my implementation. Instead of getting comments from post id, creating two different modules and getting comments from equipmentpostid and eventpostid is more clear and easy way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smooth wrapping up of comments & answers, thank you for your work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good! Renaming routes for equipments and events is also good in terms of clearness. Thanks for your tremendous effort to make it happen in such a short duration!
The comments and answers API has been implemented and works as documented on the API documentation in the wiki. The model classes were taken from the work of @ibrahimbayat and @supiket.
@KeremZaman, please keep in mind during deployment that this implementation requires a new dependency, version 0.7.1 of the drf-extensions package.
This PR will resolve #206 if merged.