Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Comments/answers API #309

Merged
merged 11 commits into from
Jan 2, 2022
Merged

[Backend] Comments/answers API #309

merged 11 commits into from
Jan 2, 2022

Conversation

ege-kaya
Copy link
Collaborator

@ege-kaya ege-kaya commented Jan 2, 2022

The comments and answers API has been implemented and works as documented on the API documentation in the wiki. The model classes were taken from the work of @ibrahimbayat and @supiket.

@KeremZaman, please keep in mind during deployment that this implementation requires a new dependency, version 0.7.1 of the drf-extensions package.

This PR will resolve #206 if merged.

Copy link
Contributor

@supiket supiket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review urls.py, views.py and tests.py for event posts and equipment posts at a later time.

backend/equipmentposts/models.py Show resolved Hide resolved
backend/eventposts/models.py Show resolved Hide resolved
Copy link
Collaborator

@ibrahimbayat ibrahimbayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good. Implementation is little different from my implementation. Instead of getting comments from post id, creating two different modules and getting comments from equipmentpostid and eventpostid is more clear and easy way.

@ege-kaya ege-kaya requested a review from supiket January 2, 2022 20:28
Copy link
Contributor

@supiket supiket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth wrapping up of comments & answers, thank you for your work!

Copy link
Collaborator

@KeremZaman KeremZaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good! Renaming routes for equipments and events is also good in terms of clearness. Thanks for your tremendous effort to make it happen in such a short duration!

@ege-kaya ege-kaya merged commit ff73b52 into development Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants