Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #314 #331

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Bug fix #314 #331

merged 2 commits into from
Jan 3, 2022

Conversation

sseff
Copy link
Collaborator

@sseff sseff commented Jan 3, 2022

When a user logs in or logs out, the page is automatically renewed.
I also fixed handleLogin part of the login to set user info.

@sseff sseff requested a review from berkaydoner January 3, 2022 14:26
@sseff sseff self-assigned this Jan 3, 2022
@sseff sseff changed the base branch from master to development January 3, 2022 14:26
Copy link
Collaborator

@berkaydoner berkaydoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the package-lock.json file? Tests are failing, maybe it is because of this file?
Also, getUserInfo() calls the setUserInfo(), I think the previous version was correctly implemented.

@sseff
Copy link
Collaborator Author

sseff commented Jan 3, 2022

I changed setUserInfo to getUserInfo, thanks for warning.

@berkaydoner berkaydoner merged commit 82899dd into development Jan 3, 2022
@berkaydoner
Copy link
Collaborator

Thanks for the revision, closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants