Refs #83 - Corrected the jsonify expression for returning database ob… #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeremZaman
requested changes
Jun 9, 2021
practice-app/app/block.py
Outdated
| @@ -11,4 +11,4 @@ | |||
| @block_api.route('/api/v1.0/<int:user_id>/blocked-users', methods=['GET']) | |||
| def get_blocked_users(user_id): | |||
| blocked_users = session.query(Blocking).filter(Blocking.blockingID == user_id).all() | |||
| return jsonify({"blockedIDs": list(blocked_users)}), 200 | |||
| return jsonify({col.name: str(getattr(blocked_users, col.name)) for col in blocked_users.__table__.columns}), 200 | |||
There was a problem hiding this comment.
Since this endpoint is for getting the users blocked by the user with given id, you don't need to return all Blocking object. Also, you tried to access object attributes from list not the object's itself. So, here is my suggestion:
Suggested change
| return jsonify({col.name: str(getattr(blocked_users, col.name)) for col in blocked_users.__table__.columns}), 200 | |
| return jsonify({"blockedIDs": [user.blockedID for user in blocked_users]}), 200 |
There was a problem hiding this comment.
Thank you for your review Kerem. I think you are correct, I am implementing your suggestion.
KeremZaman
approved these changes
Jun 10, 2021
|
Since the suggested change is implemented and approved, I am merging this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ject.
The jsonify expression in the return clause has been corrected since only calling list() is not functional.