Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding favorite games feature to the practice-app #157

Closed
9 tasks done
omersafakbebek opened this issue May 6, 2023 · 2 comments · Fixed by #184
Closed
9 tasks done

Adding favorite games feature to the practice-app #157

omersafakbebek opened this issue May 6, 2023 · 2 comments · Fixed by #184
Assignees
Labels
effort : high This issue can take a significant amount of time milestone Related to milestone reports priority : high Job needs to be completed at most two days status : completed Issue is completed type : development Updates and enhancements on the application

Comments

@omersafakbebek
Copy link
Contributor

omersafakbebek commented May 6, 2023

Issue Description

As a requirement of the practice-app, each of us should consume at least one api call and provide at least one api function. I decided on a favorite games system that uses Internal Steam Web API. The end user will search a string in the steam apps and get a list. The user will choose one of the games and the chosen game (with an identifier of the user) will be added to our database. When the end user wants to see its favorite games, the favorite games will be listed.

Tasks

Parts of the task:

  • Creating a new branch for the task
  • Creating search api function
  • Creating add to favorites api function
  • Creating remove from favorites api function
  • Creating get favorites api function
  • Testing the api functions with Postman
  • Adding documentations of the written api functions (with swagger)
  • Creating unit tests for the api functions (with jest)
  • Pushing the api functions to the created branch and creating a new pull request

Extra Comments

No response

Final Step

Interface for the feature will be created.

Deadline of the Issue

08.05.2023-17.00

Reviewer

@yunusemrealtug

Deadline for the Review

08.05.2023-23.59

@omersafakbebek omersafakbebek added type : development Updates and enhancements on the application priority : high Job needs to be completed at most two days status : in_progress Issue is currently in progress effort : high This issue can take a significant amount of time milestone Related to milestone reports labels May 6, 2023
@omersafakbebek omersafakbebek self-assigned this May 6, 2023
@omersafakbebek omersafakbebek added status : blocked Issue is blocked and removed status : in_progress Issue is currently in progress labels May 9, 2023
@omersafakbebek
Copy link
Contributor Author

The parts of the task are completed but it is needed to change some logic after the completion of #168.

@omersafakbebek omersafakbebek linked a pull request May 10, 2023 that will close this issue
@omersafakbebek
Copy link
Contributor Author

The work can be reviewed through #184.

@omersafakbebek omersafakbebek added status : need_review This issue is needed to review and removed status : blocked Issue is blocked labels May 10, 2023
@omersafakbebek omersafakbebek added status : completed Issue is completed and removed status : need_review This issue is needed to review labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort : high This issue can take a significant amount of time milestone Related to milestone reports priority : high Job needs to be completed at most two days status : completed Issue is completed type : development Updates and enhancements on the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant