Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving Information About Game Platform Feature to Practice API #159

Closed
7 of 8 tasks
yunusemrealtug opened this issue May 7, 2023 · 3 comments
Closed
7 of 8 tasks
Assignees
Labels
effort : moderate This issue can take some time priority : high Job needs to be completed at most two days status : in_progress Issue is currently in progress type : development Updates and enhancements on the application

Comments

@yunusemrealtug
Copy link
Contributor

yunusemrealtug commented May 7, 2023

Issue Description

Task

I searched about api's which related to our project, and I found out moby games, which gives user much information about many games. The planned functionalities are:

  • User should be able to search and click game which user learn its platforms. (ex. Playstation 5, MS Windows, Xbox One X...)
  • Database should keep the user's platform.

Endpoints

The views will be utilizing the following endpoints:

  1. The addPlatform is a POST method that adds user's platform information to database.
  2. The searchGames is a GET method that displays searched games by keyword.
  3. The getPlatforms is a GET method that returns the platforms of the game.

Tests

All functionalities will be tested

Swagger Documentation

I will provide Swagger documentation for the routes.

Tasks

Parts of the task:

  • Creating a new branch for the task
  • Create addPlatform method
  • Create searchGames method
  • Create getPlatforms
  • Testing the api functions with Postman
  • Adding documentations of the written api functions (with swagger)
  • Creating unit tests for the api functions (with jest)
  • Pushing the api functions to the created branch and creating a new pull request

Deadline of the Issue

10.05.2023 - Wednesday - 11.00

Reviewer

@mtkamiloglu

Deadline for the Review

10.05.2023 - Wednesday - 23:59

@yunusemrealtug yunusemrealtug changed the title Game Platform API Game Platform API Feature to Practice App May 7, 2023
@yunusemrealtug yunusemrealtug self-assigned this May 7, 2023
@yunusemrealtug yunusemrealtug added type : development Updates and enhancements on the application priority : high Job needs to be completed at most two days status : in_progress Issue is currently in progress effort : moderate This issue can take some time labels May 7, 2023
@yunusemrealtug yunusemrealtug changed the title Game Platform API Feature to Practice App Give Information About Game Platform Feature to Practice API May 7, 2023
@yunusemrealtug yunusemrealtug changed the title Give Information About Game Platform Feature to Practice API Giving Information About Game Platform Feature to Practice API May 7, 2023
@yunusemrealtug
Copy link
Contributor Author

yunusemrealtug commented May 9, 2023

I actually have written most parts of the code but we decided to add login sign in system to whole practice api so, I will update these part later, and I am updating the deadline as 10.05.2022 ,11:00.

@yunusemrealtug
Copy link
Contributor Author

yunusemrealtug commented May 10, 2023

The desirable part does not make sense now for me. Therefore, I am removing it from tasks and whole issue. Also, I pushed code into the branch and still, I can add basic function for getPlatforms part .

@mtkamiloglu
Copy link
Contributor

I reviewed the code and merged with main branch. I am closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort : moderate This issue can take some time priority : high Job needs to be completed at most two days status : in_progress Issue is currently in progress type : development Updates and enhancements on the application
Projects
None yet
Development

No branches or pull requests

2 participants