Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Function #167

Closed
6 tasks done
senaal opened this issue May 8, 2023 · 2 comments
Closed
6 tasks done

API Function #167

senaal opened this issue May 8, 2023 · 2 comments
Assignees
@senaal
Labels
effort : high This issue can take a significant amount of time priority : high Job needs to be completed at most two days status : completed Issue is completed
Milestone
A Deployed Applic...

Comments

@senaal
Copy link
Contributor

senaal commented May 8, 2023 •
edited

Issue Description

I decided RAWG API and I will find genres and game counts.

Tasks

Parts of the task:

  • Test Api at Postman.
  • Clone main project from GitHub.
  • Write controller.js.
  • Write model.js.
  • Write routes.js.
  • Write test.js.

Extra Comments

No response

Final Step

No response

Deadline of the Issue

10,05.2023

Reviewer

@omersafakbebek

Deadline for the Review

No response
@senaal senaal added priority : high Job needs to be completed at most two days status : in_progress Issue is currently in progress effort : high This issue can take a significant amount of time labels May 8, 2023
@senaal senaal self-assigned this May 8, 2023
@senaal senaal added status : need_review This issue is needed to review and removed status : in_progress Issue is currently in progress labels May 12, 2023
@senaal
Copy link
Contributor Author

senaal commented May 12, 2023

It is done and needs review. @omersafakbebek

@omersafakbebek
Copy link
Contributor

I checked the code, there are 3 api functions. The first one gets all genres from the api. The second one adds the all genres to our database with an additional info which is email. The third one gets all genres from the database with given email. These api functions does what it aims to do. But when I tried the second function twice, the app crashes due to uniqueness of genre.

@omersafakbebek omersafakbebek added status : completed Issue is completed and removed status : need_review This issue is needed to review labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senaal senaal

Labels
effort : high This issue can take a significant amount of time priority : high Job needs to be completed at most two days status : completed Issue is completed
Projects
None yet
Milestone
A Deployed Application Web Application
Development

No branches or pull requests
2 participants
@omersafakbebek @senaal