Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging user search to the Main Search Page #744

Closed
2 tasks done
frknlke opened this issue Dec 18, 2023 · 1 comment · Fixed by #745
Closed
2 tasks done

Merging user search to the Main Search Page #744

frknlke opened this issue Dec 18, 2023 · 1 comment · Fixed by #745
Assignees
@frknlke
Labels
effort : moderate This issue can take some time priority : urgent Job needs to be completed as soon as possible status : completed Issue is completed team: mobile This issue will be handled by mobile team type : development Updates and enhancements on the application
Milestone
Final Milestone

Comments

@frknlke
Copy link
Contributor

frknlke commented Dec 18, 2023 •
edited

Issue Description

I completed main search page in the mobile app. Now, I will merge user search into main search page. Thus, our search page in the mobile app will be finalized if there won't be further ideas about it.

Tasks

Parts of the task:

  • Update UI components in user search page in order to make it compatible with game and post search pages.
  • Merge user search into the main search page

Extra Comments

None

Final Step

None

Deadline of the Issue

19.12.2023 - Tuesday - 13:00

Reviewer

@senaal

Deadline for the Review

19.12.2023 - Tuesday - 15:00
@frknlke frknlke added type : development Updates and enhancements on the application priority : urgent Job needs to be completed as soon as possible status : new New issue in initial state effort : moderate This issue can take some time team: mobile This issue will be handled by mobile team labels Dec 18, 2023
@frknlke frknlke added this to the Final Milestone milestone Dec 18, 2023
@frknlke frknlke self-assigned this Dec 18, 2023
frknlke added a commit that referenced this issue Dec 18, 2023
@frknlke
#744 merged users search into main search page - mobile app
a502561
@frknlke
Copy link
Contributor Author

frknlke commented Dec 18, 2023

I completed all the subtasks, then opened a PR. After merging issue will be closed.

@frknlke frknlke linked a pull request Dec 18, 2023 that will close this issue
#744 merged users search into main search page - mobile app #745
Merged
@frknlke frknlke added status : need_review This issue is needed to review and removed status : new New issue in initial state labels Dec 18, 2023
kardelenerdal added a commit that referenced this issue Dec 18, 2023
@kardelenerdal
Merge pull request #745 from bounswe/feature/MB/744/merge-user-search…
2b07fd2 
…-to-main-search-page-mobile

#744 merged users search into main search page - mobile app
@frknlke frknlke added status : completed Issue is completed and removed status : need_review This issue is needed to review labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frknlke frknlke

Labels
effort : moderate This issue can take some time priority : urgent Job needs to be completed as soon as possible status : completed Issue is completed team: mobile This issue will be handled by mobile team type : development Updates and enhancements on the application
Projects
None yet
Milestone
Final Milestone
Development

Successfully merging a pull request may close this issue.

#744 merged users search into main search page - mobile app bounswe/bounswe2023group7
1 participant
@frknlke