feature/MB/460/create_game_page #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kardelenerdal
added
type : development
4 tasks
haticerk
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
I like the division between the create_game scenes, which helps a lot to keep track of writing. I also find making some fields static and rollability between options useful. Finally five seconds is a reasonable amount of time to back to the games page.
Later, I think this create game page should navigate to the game page. We can make this adaption after the game page is ready.
I appreciate your work. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I divided the create game page into two pages. For platforms, i made a dropdown menu. For age restriction, I implemented an iOS-style menu as we have decided. For release date, I added a date picker. If the game is created successfully, a message pops up and if you click OK, you will be redirected to the games page. If the game can't created, the related error message pops up. I also made some of the boxes (game bio, etc.) bigger since the input may be longer. For static options in platforms or age restrictions, we can always add or remove new items.