Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#466 tokenization for mobile app #493

Merged
merged 1 commit into from Nov 21, 2023
Merged

#466 tokenization for mobile app #493

merged 1 commit into from Nov 21, 2023

Conversation

frknlke
Copy link
Contributor

@frknlke frknlke commented Nov 20, 2023

I have added tokenization mechanism in necessary places in order to prevent non registered user from reaching exclusive forum contents. Also added token for some of API requests' headers.

@frknlke frknlke added type : enhancement New feature or request priority : high Job needs to be completed at most two days status : need_review This issue is needed to review effort : moderate This issue can take some time milestone Related to milestone reports team: mobile This issue will be handled by mobile team labels Nov 20, 2023
@frknlke frknlke added this to the Milestone 2 milestone Nov 20, 2023
@frknlke frknlke self-assigned this Nov 20, 2023
@frknlke frknlke linked an issue Nov 20, 2023 that may be closed by this pull request
Adding Tokenization to API Requests Made from Mobile App #466
Closed
2 tasks
@frknlke frknlke mentioned this pull request Nov 20, 2023
Closed
2 tasks
senaal
senaal approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@senaal senaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokenization looks great, I tried to load games page before logged in and it gave pop-up message. Thank you for your effort.

@senaal senaal merged commit 7c4c45f into development Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senaal senaal senaal approved these changes

@kardelenerdal kardelenerdal Awaiting requested review from kardelenerdal

@haticerk haticerk Awaiting requested review from haticerk

Assignees

@frknlke frknlke

Labels
effort : moderate This issue can take some time milestone Related to milestone reports priority : high Job needs to be completed at most two days status : need_review This issue is needed to review team: mobile This issue will be handled by mobile team type : enhancement New feature or request
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

Adding Tokenization to API Requests Made from Mobile App
2 participants
@frknlke @senaal