Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#469 mobile-user-profile-page #578

Merged
merged 3 commits into from Nov 27, 2023
Merged

#469 mobile-user-profile-page #578

merged 3 commits into from Nov 27, 2023

Conversation

frknlke
Copy link
Contributor

@frknlke frknlke commented Nov 26, 2023

I created user profile page for mobile app. Review is strongly needed.

@frknlke frknlke added type : enhancement New feature or request priority : high Job needs to be completed at most two days status : need_review This issue is needed to review effort : high This issue can take a significant amount of time milestone Related to milestone reports team: mobile This issue will be handled by mobile team labels Nov 26, 2023
@frknlke frknlke added this to the Milestone 2 milestone Nov 26, 2023
@frknlke frknlke self-assigned this Nov 26, 2023
@frknlke frknlke linked an issue Nov 26, 2023 that may be closed by this pull request
Creating First Version of User Profile Page in Mobile App #469
Closed
2 tasks
@senaal
Copy link
Contributor

senaal commented Nov 26, 2023

It looks very nice and functional. Maybe we can upload a mock avatar for users who do not upload photos. Thanks for your effort.

@haticerk haticerk force-pushed the feature/MB/469/mobile-user-profile-page branch from b753df7 to 0408ded Compare November 27, 2023 10:19
haticerk
haticerk approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@haticerk haticerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes.

@haticerk haticerk merged commit b94a2fb into development Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haticerk haticerk haticerk approved these changes

@kardelenerdal kardelenerdal Awaiting requested review from kardelenerdal

@senaal senaal Awaiting requested review from senaal

Assignees

@frknlke frknlke

Labels
effort : high This issue can take a significant amount of time milestone Related to milestone reports priority : high Job needs to be completed at most two days status : need_review This issue is needed to review team: mobile This issue will be handled by mobile team type : enhancement New feature or request
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

Creating First Version of User Profile Page in Mobile App
3 participants
@frknlke @senaal @haticerk