Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arranged tags/platforms & enhanced components #583

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Arranged tags/platforms & enhanced components #583

merged 1 commit into from
Nov 26, 2023

Conversation

elifkizilky
Copy link
Contributor

I added the tags & platforms section as we discussed how we should proceed with the mobile team. Right now, they are synced. I also made some enhancements to sidebar and thread component.

Changes Made

  • Expanded the list of the predefined tags & platforms
  • Comment text should not be empty check is added
  • Non registered users redirected to sign up page if attempted to comment functionality is added
  • Image section is added to thread components
  • Game name is fixed in home page
  • Create Game button navigates to signup page if user is not logged in check is added.

Related Issues

#513 , #514

@elifkizilky elifkizilky self-assigned this Nov 26, 2023
@elifkizilky elifkizilky added type : enhancement New feature or request type : development Updates and enhancements on the application priority : high Job needs to be completed at most two days status : need_review This issue is needed to review effort : low This issue can be easily handled team: frontend This issue will be handled by frontend team labels Nov 26, 2023
@elifkizilky elifkizilky added this to the Milestone 2 milestone Nov 26, 2023
yunusemrealtug
yunusemrealtug approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@yunusemrealtug yunusemrealtug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were necessary to create consistent content. Thanks

@yunusemrealtug yunusemrealtug merged commit 73db3e7 into development Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunusemrealtug yunusemrealtug yunusemrealtug approved these changes

Assignees

@elifkizilky elifkizilky

Labels
effort : low This issue can be easily handled priority : high Job needs to be completed at most two days status : need_review This issue is needed to review team: frontend This issue will be handled by frontend team type : development Updates and enhancements on the application type : enhancement New feature or request
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elifkizilky @yunusemrealtug