Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user search on mobile search page #682

Merged
merged 1 commit into from Dec 12, 2023
Merged

user search on mobile search page #682

merged 1 commit into from Dec 12, 2023

Conversation

frknlke
Copy link
Contributor

@frknlke frknlke commented Dec 12, 2023

I implemented user search as I mentioned in the issue. Review is needed before merging into development.

@frknlke frknlke added type : enhancement New feature or request priority : urgent Job needs to be completed as soon as possible status : need_review This issue is needed to review effort : moderate This issue can take some time team: mobile This issue will be handled by mobile team labels Dec 12, 2023
@frknlke frknlke added this to the Final Milestone milestone Dec 12, 2023
@frknlke frknlke self-assigned this Dec 12, 2023
@frknlke frknlke linked an issue Dec 12, 2023 that may be closed by this pull request
Main Search Page - Search for a User #678
Closed
2 tasks
kardelenerdal
kardelenerdal approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kardelenerdal kardelenerdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your code and tried to search games and users on my emulator. The tests are successfull. Thank you for your efforts, well done

@kardelenerdal kardelenerdal merged commit bafd6ae into development Dec 12, 2023
@frknlke frknlke linked an issue Dec 17, 2023 that may be closed by this pull request
Creating main search page for the mobile app #643
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kardelenerdal kardelenerdal kardelenerdal approved these changes

@haticerk haticerk Awaiting requested review from haticerk

@senaal senaal Awaiting requested review from senaal

Assignees

@frknlke frknlke

Labels
effort : moderate This issue can take some time priority : urgent Job needs to be completed as soon as possible status : need_review This issue is needed to review team: mobile This issue will be handled by mobile team type : enhancement New feature or request
Projects
None yet
Milestone
Final Milestone
Development

Successfully merging this pull request may close these issues.

Main Search Page - Search for a User Creating main search page for the mobile app
2 participants
@frknlke @kardelenerdal