Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating API URLs to Use Hyphens for Word Separation #157

Closed
2 tasks done
laylaylo opened this issue May 11, 2023 · 1 comment · Fixed by #158
Closed
2 tasks done

Updating API URLs to Use Hyphens for Word Separation #157

laylaylo opened this issue May 11, 2023 · 1 comment · Fixed by #158
Assignees
@laylaylo
Labels
difficulty: easy Requires basic skills and knowledge. priority: low This issue can be addressed later if necessary. size: small Can be completed quickly and without significant effort. type: fix This label should be applied to issues and pull requests that contain a fix .
Milestone
CMPE352 Practice ...

Comments

@laylaylo
Copy link
Contributor

laylaylo commented May 11, 2023 •
edited

Issue Description

Just a heads up, I plan on changing all word separations in URLs to be hyphens instead of underscores.

Why?

This is in line with the standard best practice for REST APIs, as recommended in Mark Masse's "REST API Design Rulebook" from O'Reilly.

you can take a look at this stack overflow post.

Steps

  • change URLs in url.py
  • change URLs being used in test.py

Deadline for the Issue

No response
@laylaylo laylaylo added priority: low This issue can be addressed later if necessary. type: enhancement This issue suggests enhancement to the existing functionality of the project or code. status: in-progress size: small Can be completed quickly and without significant effort. difficulty: easy Requires basic skills and knowledge. labels May 11, 2023
@laylaylo laylaylo self-assigned this May 11, 2023
@laylaylo laylaylo linked a pull request May 11, 2023 that will close this issue
updating API URLs to use hyphens #158
Merged
@laylaylo laylaylo mentioned this issue May 11, 2023
Merged
@laylaylo
Copy link
Contributor Author

laylaylo commented May 11, 2023 •
edited

Pull Request #157 is created and waits for the review.

@laylaylo laylaylo added status: completed type: fix This label should be applied to issues and pull requests that contain a fix . and removed status: needs-review type: enhancement This issue suggests enhancement to the existing functionality of the project or code. labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laylaylo laylaylo

Labels
difficulty: easy Requires basic skills and knowledge. priority: low This issue can be addressed later if necessary. size: small Can be completed quickly and without significant effort. type: fix This label should be applied to issues and pull requests that contain a fix .
Projects
None yet
Milestone
CMPE352 Practice Application: A Deplo...
Development

Successfully merging a pull request may close this issue.

updating API URLs to use hyphens bounswe/bounswe2023group9
1 participant
@laylaylo