Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Annotation Implementation #634

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

omerfaunal
Copy link
Contributor

Implemented Annotation feature for texts but not connected it to the backend yet.

Copy link
Contributor

@laylaylo laylaylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, giving option to show latex or annotations is best we can under discussed circumstances #565

SizedBox(
width: 180,
child: AppButton(
text: showAnnotations ? "Show Text" : "Show Annotations",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 'Show Annotation' button for each proof but actually they should be all in same state, I think moving these buttons from each proof card to the only one to top of them is more clear design but this version also have advantages to change it while in bottom of the page. So we can discuss it with frontend team later.

@laylaylo laylaylo merged commit bb3b585 into frontend Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants